-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support caching results on Win32-based systems #832
base: main
Are you sure you want to change the base?
Conversation
Thanks for your PR, @dbehmoaras! This is the central function to normalize paths to posix format. So I'm not sure whether this is the right location to fix the issue. What's the exact issue you're trying to solve here? |
Hmm - I see your point. Maybe then it should be addressed in file that handles the caching of the results ? The issue we run into is that Knip fails to update the cache on windows systems because it resolves a posix file path when windows env expects a win32 path from node.js - see permalink below:
Is there a separate file that handles win32 file paths ? Open to any approach |
Alright, clear. Maybe you can |
Ok let me try that |
Great, I'm asking so you can directly test it works properly on Windows. If you update the PR, you will automatically get a new version that you can |
commit: |
…ct creation